Fix #9337 — recognize compact -T<n> and --threads=<n> Maven flags#9382
Merged
matthiasblaesing merged 1 commit intoMay 19, 2026
Merged
Conversation
matthiasblaesing
added
Maven
matthiasblaesing
approved these changes
May 8, 2026
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Thank you.
The failing test can be ignored, it is a problem in the verification.
@sdedic would you mind having a look at this? You worked in the maven area, so it might be of interest.
Contributor
|
@xerno thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetBeans only detected the spaced forms (
-T 2,--threads 2) as parallel builds. The compact forms (-T2) and GNU-style equals form (--threads=2) were not recognized, so for multi-module projects NetBeans kept its output tree-folding active and crashed with an NPE inCommandLineOutputHandler.trimTreewhen concurrent module events arrived (Cannot read field "type" because "start" is null).Extracts a
threadsArgValue()helper that recognizes all four forms and uses it from bothisMultiThreadedMavenandisMultiThreadedMvnd.Side effects, both intentional improvements
-T1now correctly flips to single-threaded mode (previously only the spaced-T 1did).-T(e.g.-Tfoo) is now reported as the threads value verbatim; Maven itself rejects such input.Tests
Added cases for
-T2,-T10,-T1C,-T1,--threads=2,--threads=1, and a dangling-Tto bothMavenCommandParametersAnalyzerTestandMavenDaemonCommandParametersAnalyzerTest.